Closed rymarinelli closed 1 year ago
@seth127 I tried to add additional logic to address if threads is NULL. If threads is null, the handling present in check_bbi_args
will raise with a type error. Since NULL
is not a numeric, it will error here.
# check type
if (ref$type == "character") {
type_pass_bool <- is_bare_character(.v)
} else if (ref$type == "logical") {
type_pass_bool <- is_bare_logical(.v)
} else if (ref$type == "numeric") {
type_pass_bool <- is_bare_numeric(.v)
} else {
# This feels weird to put an intentional bug catch in here, but I don't like having to rely on raw string matching
# from our aaa.R file to trigger functionality, so this feels like the safest option.
stop(paste0("BUG!!! BBI_ARGS[['", .n, "']][['type']] is `", ref$type, "` which is invalid.
Must be either 'character', 'logical', or 'numeric'"))
Just noting on here that this comment above led to creating https://github.com/metrumresearchgroup/bbr/issues/555. I'm not sure if that needs to be addressed before this PR or not, but it might.
Hmm, that's a nasty error for the mpn oldest/R4.0 check build:
*** caught segfault ***
address 0x55be988d32d0, cause 'invalid permissions'
The push build passed, so I'm not confident we're going to be able to retrigger and investigate that.
I'd suggest restarting the build (via the drone interface) to see whether it persists.
Closes #553