Closed kyleam closed 1 year ago
Here's a CI build that is running with the latest tidyr (i.e. the build that would fail before this commit): https://github-drone.metrumrg.com/metrumresearchgroup/bbr/3401/3/5
I'll push a scratch build off of main to demonstrate the failure (hopefully). I believe a vignette will be failing too.
Update: here it is. It's just the vignette failure because it doesn't proceed to running the tests, but that works for showing the issue.
@barrettk Thanks for taking a look.
With the recent tidyr 1.3.0 release, two summary log tests are failing:
The value triggering these failures looks like this:
That NA comes from extract_details() indexing the run details with DETAILS_ELEMENTS, which includes "estimation_method", but the value for the acop-onlysim model doesn't have an estimation_method element.
Handle this case by only indexing with names that exist for a given model's run details.
cc @seth127 for awareness