search

metrumresearchgroup / bbr

R interface for model and project management
https://metrumresearchgroup.github.io/bbr/
Other
23 stars 2 forks source link

nm_data doesn't work on unfinished models #595

Closed seth127 closed 5 months ago

seth127 commented 1 year ago

nm_data() doesn't work on a model that hasn't been run successfully (because it relies on pulling the data path from the json config, which won't be there if the model hasn't be run successfully).

Importantly, this also means nm_join() and friends don't work, because they call nm_data().

seth127 commented 5 months ago

This just came up again and I agree that using nmrec to get this from the control stream seems like a good move.

In terms of my comment from almost a year ago about nm_join() failing because of this... I'm not sure what I was getting there. While true, it's not obvious why a user would expect to be able to call nm_join() on a model that hasn't been run, notably because the table files wouldn't exist yet.