metrumresearchgroup / bbr

R interface for model and project management
https://metrumresearchgroup.github.io/bbr/
Other
23 stars 2 forks source link

Inherit parameter estimates #608

Closed barrettk closed 8 months ago

barrettk commented 10 months ago
barrettk commented 9 months ago

@seth127 FYI I got all the current tests passing:tada:. I left some details in the commit message, but basically wanted to add support for the items discussed in the confluence docs to facilitate the transition of some of that to nmrec. I think that will make the first conversation easier.

Though this code is far from the finish line and can definitely be improved, I think it's actually pretty robust so far (minus untested/unsupported cases) due to the rigidity of nmrec parsing. After the latest commit I feel significantly better about being able to support many common NONMEM record specifications, and just wanted to share some of the optimism.

At the moment I would draw attention to get_record_attr and filter_prior_records as targets for migrating to nmrec. However, it should be noted that the main function that does the copying (copy_record_opt) also relies pretty heavily on nmrec, and currently uses an internal function for amending the bounds of theta records (which I have no intention leaving as-is). nmrec is used pretty heavily across many of the other functions as well (almost all of them), so i'd like to identify a clear line where it makes sense to move certain operations to nmrec.

seth127 commented 9 months ago

Thanks @barrettk. Glad to hear it!

I scheduled some time for us to look at this together tomorrow, and then we can make a plan to engage with @kyleam , probably next week to discuss what lives where.

kyleam commented 9 months ago

(changing base to main since dev-nmrec was merged in gh-606, and I'm about to delete the branch)

barrettk commented 8 months ago

This PR is superseded by https://github.com/metrumresearchgroup/bbr/pull/623