metrumresearchgroup / bbr

R interface for model and project management
https://metrumresearchgroup.github.io/bbr/
Other
22 stars 2 forks source link

bug fix: dont tabulate threads before deleting models. #625

Closed barrettk closed 7 months ago

barrettk commented 7 months ago

To reproduce this bug, you can run this test:

test_that("delete_models", {
  mod <- read_model(file.path(MODEL_DIR_X, "example2_saemimp"))
  mod_est <- copy_model_from(mod, "mod_est", "Inherit estimates", .overwrite = TRUE)
  delete_models(mod_est, .tags = NULL, .force = TRUE)
  expect_true(1==1)
})

pkgr file for reproducing this environment:

Version: 1
Descriptions:
  - DESCRIPTION

Packages:
  - devtools
  - pkgdown
  - styler

Repos:
  - MPN: https://mpn.metworx.com/snapshots/stable/2020-06-08

Lockfile:
  Type: renv

Rpath: ${R_EXE_4_0}
barrettk commented 7 months ago

@kyleam I didnt add a new test for this bug since I only deleted the problematic line. However let me know if I should add something like the test above