metrumresearchgroup / bbr

R interface for model and project management
https://metrumresearchgroup.github.io/bbr/
Other
22 stars 2 forks source link

test-initial-estimates.R: missing skips for old nmrec #658

Closed kyleam closed 4 months ago

kyleam commented 4 months ago

Running with an nmrec before 0.4.0, two tests fail.

── Failed tests ───────────────────────────────────────────────────────────────────────────────────────────────
Error ('test-initial-estimates.R:6:5'): initial_estimates: matrix_to_df
Error in `test_nmrec_version(.min_version = "0.4.0")`: This function requires at least `nmrec 0.4.0`.
Backtrace:
    ▆
 1. └─bbr:::get_initial_est(MOD1) at test-initial-estimates.R:6:5
 2.   └─bbr:::test_nmrec_version(.min_version = "0.4.0") at bbr/R/initial-estimates.R:93:3
 3.     └─rlang::abort(err_msg) at bbr/R/bbr.R:283:5

Error ('test-initial-estimates.R:116:5'): initial_estimates: initial_estimates: warns when using old priors
Error in `test_nmrec_version(.min_version = "0.4.0")`: This function requires at least `nmrec 0.4.0`.
Backtrace:
    ▆
 1. ├─testthat::expect_warning(...) at test-initial-estimates.R:116:5
 2. │ └─testthat:::quasi_capture(...) at testthat/R/expect-condition.R:170:5
 3. │   ├─testthat (local) .capture(...) at testthat/R/quasi-label.R:54:3
 4. │   │ └─base::withCallingHandlers(...) at testthat/R/deprec-condition.R:102:3
 5. │   └─rlang::eval_bare(quo_get_expr(.quo), quo_get_env(.quo)) at testthat/R/quasi-label.R:54:3
 6. └─bbr::initial_estimates(mod_c) at rlang/R/eval.R:96:3
 7.   └─bbr:::get_initial_est(.mod, flag_fixed = flag_fixed) at bbr/R/initial-estimates.R:28:3
 8.     └─bbr:::test_nmrec_version(.min_version = "0.4.0") at bbr/R/initial-estimates.R:93:3
 9.       └─rlang::abort(err_msg) at bbr/R/bbr.R:283:5

cc: @barrettk