metrumresearchgroup / bbr

R interface for model and project management
https://metrumresearchgroup.github.io/bbr/
Other
21 stars 2 forks source link

ci: switch to GitHub Actions #681

Closed kyleam closed 1 week ago

kyleam commented 2 months ago

This series switches the CI from Drone to GitHub Actions. The goal is to preserve important features, including coverage measurement and the "oldest" job.

The main switch happens in the third commit. The fourth commits takes care of gh-550 by adding a check_pkgdown() step.


kyleam commented 2 months ago

Test s3 auth and dry-run upload look good:

I'll drop the tip commit.

barrettk commented 2 months ago

Drive by comment: We have an open issue about dropping those two packages that can be closed once this is merged: https://github.com/metrumresearchgroup/bbr/issues/629

kyleam commented 2 months ago

We have an open issue about dropping those two packages that can be closed once this is merged:

629

Thanks for the reminder. Updated that commit to auto-close that issue.

kyleam commented 1 month ago

Pushed update to pull shared actions from new repo at https://github.com/metrumresearchgroup/actions.

kyleam commented 3 weeks ago

I'll return this to a draft because 1) the plan is to hold off on this until after the upcoming release and 2) I'll need to resolve the conflict and make a tweak to the oldest build for the addition of mrgmisc dependency.

For reference, here's a scratch actions run that brings in the current tip of feat/vpc (f81cf2d4): https://github.com/metrumresearchgroup/bbr/actions/runs/9504620205

kyleam commented 1 week ago

I've rebased and resolved the conflicts.

Notable changes:

kyleam commented 1 week ago

I said:

The oldest build now uses the 2023-01-25 snapshot

I think everyone is agreement that we are long overdue for a bump here. There may be some disagreement about whether 2023-01-25 is too recent. However, at this point, this is the effective minimum snapshot since the 1.11.0 release.

So my vote would be for discussion of that to not hold up merging this PR. We can create a dedicated issue to discuss whether we want to make changes to push back the minimum required snapshot.

barrettk commented 1 week ago

@kyleam I went through all your recent commits/refactors and agree with your perspective on opening a dedicated PR if we wanted to dial back the oldest snapshot/revisit version requirements. A shame we missed some of these things by deleting the mpn-oldest checks, but im also glad we're finally bumping the required cli version (purrr bump is nice too). Fingers crossed those two dont get dialed back, though I agree the oldest snapshot does feel a bit recent (I personally have no objections given how MPN works though).

kyleam commented 1 week ago

@barrettk Thanks for the careful review.