Closed kyleam closed 1 week ago
Test s3 auth and dry-run upload look good:
I'll drop the tip commit.
Drive by comment: We have an open issue about dropping those two packages that can be closed once this is merged: https://github.com/metrumresearchgroup/bbr/issues/629
We have an open issue about dropping those two packages that can be closed once this is merged:
629
Thanks for the reminder. Updated that commit to auto-close that issue.
Pushed update to pull shared actions from new repo at https://github.com/metrumresearchgroup/actions.
I'll return this to a draft because 1) the plan is to hold off on this until after the upcoming release and 2) I'll need to resolve the conflict and make a tweak to the oldest build for the addition of mrgmisc dependency.
For reference, here's a scratch actions run that brings in the current tip of feat/vpc
(f81cf2d4): https://github.com/metrumresearchgroup/bbr/actions/runs/9504620205
I've rebased and resolved the conflicts.
Notable changes:
The 4.0.5 and 4.1.3 builds have been updated to 4.2.3 and 4.3.1 to match the two most recent R versions on the latest AMI. R 4.0.5 is still tested in the "oldest" job.
The oldest build now uses the 2023-01-25 snapshot. An increase is required due to functionality that bbr v1.11.0 started using, and this particular snapshot is required to get purrr v1.0.0.
Relevant commits:
I said:
The oldest build now uses the 2023-01-25 snapshot
I think everyone is agreement that we are long overdue for a bump here. There may be some disagreement about whether 2023-01-25 is too recent. However, at this point, this is the effective minimum snapshot since the 1.11.0 release.
So my vote would be for discussion of that to not hold up merging this PR. We can create a dedicated issue to discuss whether we want to make changes to push back the minimum required snapshot.
@kyleam I went through all your recent commits/refactors and agree with your perspective on opening a dedicated PR if we wanted to dial back the oldest snapshot/revisit version requirements. A shame we missed some of these things by deleting the mpn-oldest
checks, but im also glad we're finally bumping the required cli
version (purrr
bump is nice too). Fingers crossed those two dont get dialed back, though I agree the oldest snapshot does feel a bit recent (I personally have no objections given how MPN works though).
@barrettk Thanks for the careful review.
This series switches the CI from Drone to GitHub Actions. The goal is to preserve important features, including coverage measurement and the "oldest" job.
The main switch happens in the third commit. The fourth commits takes care of gh-550 by adding a
check_pkgdown()
step.[x] Drop tip commit that tests dry-run s3 sync.
[x] After approval and right before merge, adjust the required status checks in the branch protection settings.
[ ] Coordinate with open pull requests. Once this is merged, these PRs should bring this in (by merge or rebase) to move away from Drone.