metrumresearchgroup / example-models

Moved from Charles' own github - July 31, 2017
10 stars 4 forks source link

Restructure example scripts and folders #15

Open billgillespie opened 5 years ago

billgillespie commented 5 years ago

I propose to implement the following changes to the examples:

billgillespie commented 5 years ago

In branch issue-15-restruct I pushed a revised version of the TwoCptModel example. Comments welcome about extending this approach to the remaining example---or changing it.

charlesm93 commented 5 years ago

Hi Bill, this is all sounds good to me. I would consider grouping models which work on the same data, but use a different method. For example, two Cpt can be specified with an analytical, a matrix exp, and a numerical solution. Similarly, the FK model can be fitted with a numerical integrator or with a mixed solver.

This means having more than one model in the directory. The other files remain unchanged. In the R script, the user can specify which model they use.

yizhang-yiz commented 5 years ago

It's a good layout. Every model should be orthogonal to the others, so that it can be shipped and reproduced separately.