search

metrumresearchgroup / ghpm

BSD 3-Clause Clear License
1 stars 0 forks source link

pluralization and nomenclature review #5

Open dpastoor opened 4 years ago

dpastoor commented 4 years ago

We need to assess the pluralization patterns. Things that return or act on multiple should be pluralized.

get_issue_comments currently returns comments for all issues. That should be get_issues_comments

Blackglade commented 4 years ago

I'm not sure if a user would really notice the pluralization that much and they could always just do ?get_issue_comments which would bring up the help page on it that clearly specifies it get's all comments from all issues. I always look at the help page anyway before I call an unfamiliar function.

Also get_issues_comments doesn't roll as nicely off the tongue