search

metrumresearchgroup / mrgsolve

Simulate from ODE-based population PK/PD and QSP models in R
https://mrgsolve.org
GNU General Public License v2.0
132 stars 36 forks source link

Drop cxx11 #1060

Closed kylebaron closed 1 year ago

kylebaron commented 1 year ago

This PR drops any statement of a C++ standard. This seems to be required See: https://cran.r-project.org/web/checks/check_results_mrgsolve.html

A lot of people are saying to just drop it. I'd personally rather just leave it in but it looks like CRAN is going to complain if it finds CXX11.

One question I have: should we start depending on a later version of R? Maybe it's time to bump that up. I don't think there is much to worry about wrt CXX version if R >= 4.0.

https://developer.r-project.org/blosxom.cgi/R-devel/2023/02/21#n2023-02-21 https://cran.r-project.org/doc/manuals/r-devel/R-exts.html#C-standards

kylebaron commented 1 year ago

Thanks @kyleam; I did end up. bumping to >= 3.6.2. Good suggestion.