search

metrumresearchgroup / mrgsolve

Simulate from ODE-based population PK/PD and QSP models in R
https://mrgsolve.org
129 stars 36 forks source link

SIgn compare #1217

Open kylebaron opened 1 month ago

kylebaron commented 1 month ago

Discovered when running check on winbuilder preparing for 1.5.0 release. 

datarecord.cpp: In function 'void insert_record(reclist&, int, rec_ptr&, bool)':
datarecord.cpp:600:26: warning: comparison of integer expressions of different signedness: 'int' and 'std::deque<std::shared_ptr<datarecord> >::size_type' {aka 'long long unsigned int'} [-Wsign-compare]
  600 |     for(i = start + 1; i < thisi.size(); ++i) {
      |                        ~~^~~~~~~~~~~~~~
datarecord.cpp:606:26: warning: comparison of integer expressions of different signedness: 'int' and 'std::deque<std::shared_ptr<datarecord> >::size_type' {aka 'long long unsigned int'} [-Wsign-compare]
  606 |     for(i = start + 1; i < thisi.size(); ++i) {
      |                        ~~^~~~~~~~~~~~~~