Release/1.5.1

[kylebaron]

mrgsolve 1.5.1

• Fixed yaml_to_cpp() example code to prevent saving the file to the working directory (#1220).

[kyleam]

I didn't see it prior to submitting, but I didn't run check with --as-cran; you can see it then.

Ah, bummer. I even glanced at the CI output but missed it. Example: https://github.com/metrumresearchgroup/mrgsolve/actions/runs/10102113645/job/27937084078

[kylebaron]

It was my fault; I usually check this before releasing, especially if I'm expecting to send it to CRAN. The NOTE is obvious locally if I just ran check that way.

Kind of disappointed Winbuilder didn't pick this up, though.

This was discovered on CRAN pretest. I didn't see it prior to submitting, but I didn't run check with --as-cran; you can see it then.

Found the following files/directories:
  ‘file60fa5b946f7b.yaml.mod’
* checking for detritus in the temp directory ... OK
* DONE

Status: 1 NOTE
See
  ‘/Users/kyleb/git/m4solve/mrgsolve.Rcheck/00check.log’
for details.

With the updated example code, you don't get the note.

[kyleam]

The CI runs with --as-cran. At some point, I think it'd be nice to get the CI to flag any unexpected notes. Here are the three notes on the CI build I pointed to above:

2024-07-25T22:04:48.7537179Z * checking installed package size ... NOTE
2024-07-25T22:04:48.7538064Z   installed size is 19.2Mb
2024-07-25T22:04:48.7543667Z   sub-directories of 1Mb or more:
2024-07-25T22:04:48.7547850Z     R      1.2Mb
2024-07-25T22:04:48.7548428Z     libs  16.5Mb
[...]
2024-07-25T22:05:47.1125270Z * checking HTML version of manual ... NOTE
2024-07-25T22:05:47.1128545Z Skipping checking HTML validation: no command 'tidy' found
2024-07-25T22:05:47.1130382Z * checking for non-standard things in the check directory ... NOTE
2024-07-25T22:05:47.1132547Z Found the following files/directories:
2024-07-25T22:05:47.1133500Z   ‘file3b11edea6c0.yaml.mod’
[...]
2024-07-25T22:05:47.1148224Z Status: 3 NOTEs

• We should be able to silence the size one by tweaking _R_CHECK_PKG_SIZES_.

• For the HTML validation, I'd guess it's easy enough to install tidy (haven't looked into what it is but likely available via apt).

That'd leave us expecting a clean build, and we could error if any notes were found. (With the rcmdcheck-based r-lib/actions/check-r-package@v2, we could pass with: error-on: '"note"'. Although mrgsolve doesn't use check-r-package, adding custom logic to the make ci target to flag it shouldn't be too bad.)