metrumresearchgroup / mrgsolve

Simulate from ODE-based population PK/PD and QSP models in R
https://mrgsolve.org
GNU General Public License v2.0
130 stars 36 forks source link

ADDL doses with lag time don't get positioned correctly #424

Closed kylebaron closed 5 years ago

kylebaron commented 5 years ago

This seems to be a regression with respect to 0.8.12

NONMEM has ADDL doses prior to observation; regardless of recsort option, the dose is after the observation.

This only affects simulated values (observations) exactly at the time of the dose. Purely record sort discrepancy with NONMEM. But it should respond to recsort to get exact answer.

recsort was getting handled properly; the calculation of the proper position was incorrect.

NMTEST 8 and 9

kylebaron commented 5 years ago

Add a test for this.