Fix/issue 41 - Githubissues

metrumresearchgroup / mrgvalprep

Helpers for prepping inputs to mrgvalidate

https://metrumresearchgroup.github.io/mrgvalprep

Other

1 stars 0 forks source link

Fix/issue 41 #42

Closed barrettk closed 2 years ago

barrettk commented 2 years ago

This PR is mainly to fix issue #41. However, additional changes may follow that make converting packages yspec, mrgsolve, pmplots, pmtables, mrggsave, and templ, to yaml stories easier and with less manual manipulation.

So far 2 new function arguments have been added

closes #41

barrettk commented 2 years ago

Added a new function argument that makes manually adding more tests easier, by allowing users to return the warning messages. Here's one use case:

missed_tests <- milestone_to_test_id(stories_df = stories_df, tests = test_ids, return_warnings = TRUE)$missing_milestones
missed_tests %>% dplyr::count(TestFile) %>% dplyr::arrange(desc(n))

barrettk commented 2 years ago

There are likely to be additional changes to the function when we tackle mrgsolve. Not sure if we want to pile them up on this PR, or create new ones as issues arise.

kyleam commented 2 years ago

Not sure if we want to pile them up on this PR, or create new ones as issues arise.

Please create separate, dedicated PRs.

kyleam commented 2 years ago

Note that tightening this regex also fixes #40