metrumresearchgroup / mrgvalprep

Helpers for prepping inputs to mrgvalidate
https://metrumresearchgroup.github.io/mrgvalprep
Other
1 stars 0 forks source link

treewide: don't use .data in tidy selection context #53

Closed kyleam closed 1 year ago

kyleam commented 1 year ago

tidyselect deprecated using .data in the selection context, leading to our tests generating many warnings like this:

Warning ('test-stories-to-yaml.R:5'): stories_to_yaml() works correctly with google sheet
Use of .data in tidyselect expressions was deprecated in tidyselect
1.2.0.
ℹ Please use `"StoryDescription"` instead of `.data$StoryDescription`

Switch all of these spots over to using the string form.


After these changes, the full test suite passes (including MRGVALIDATE_TEST_GHE- and {GHE,GH}_PAT-guarded tests) when executed under Rscript -e 'options(warn = 2)' -e 'devtools::test()'.

More information: https://www.tidyverse.org/blog/2022/10/tidyselect-1-2-0/#using-data-inside-selections