search

metrumresearchgroup / pkgr

R package installation and management - reimagined.
https://metrumresearchgroup.github.io/pkgr/docs
39 stars 4 forks source link

refactor: use noupdate to normalize to the inverse pattern elsewhere and change default #377

Closed dpastoor closed 3 years ago

dpastoor commented 3 years ago

it has found that the default behavior to not update is generally not what users want, especially around reproducibility. Instead, we want users to be able to not update only if they absolutely need to.

In addition, part of this original decision was to prevent packages attempting to be updated causing major failures that couldn't get back to original state. This is no longer an issue given the rollback functionality.

Dreznel commented 3 years ago

It's not a problem for our Drone tests, but I have discovered that pkgr does not automatically rebuild and reinstall prior to running our E2E tests locally. We may wish to address this going forward.

Dreznel commented 3 years ago

@dpastoor I think I found a fairly major problem with the change: image

The above screenshot shows that the multi-repo test is failing after the change. I believe this is because the --update flag used to scan all listed repositories for later versions of packages. Since that is now the default, pkgr will only respect repository order if the NoUpdate flag is true.

Dreznel commented 3 years ago

Hmm... possibly a false alarm actually, I can't replicate this issue. I'll keep looking into it