search

metrumresearchgroup / pkgr

R package installation and management - reimagined.
https://metrumresearchgroup.github.io/pkgr/docs
39 stars 4 forks source link

Fix failing test: TestMixedSource/[MXSRC-E2E-002]_repo_and_package_customizations_synchronize_when_compatible #386

Closed elisarver closed 2 years ago

elisarver commented 3 years ago 
=== RUN   TestMixedSource/[MXSRC-E2E-002]_repo_and_package_customizations_synchronize_when_compatible
    mixed_source_test.go:91: 
            Error Trace:    mixed_source_test.go:91
            Error:          Should be true
            Test:           TestMixedSource/[MXSRC-E2E-002]_repo_and_package_customizations_synchronize_when_compatible
            Messages:       expected 'digest' version 0.6.25 installed from binary
                            Actual pkg plan:
                            msg: 'package repository set', pkg: 'R6', version: '2.5.0', repo: 'MPNSource', relationship: user_defined', type: source
                            msg: 'package repository set', pkg: 'digest', version: '0.6.25', repo: 'MPNBinary', relationship: user_defined', type: source
--- FAIL: TestMixedSource (7.23s)
Dreznel commented 3 years ago

Hi @elisarver,

This is actually a valid test that is failing for a real reason (see #329). This is essentially a "known issue," but I since it's real, I don't think the test should be removed.

I can take a crack at fixing the underlying issue later this week, but I can't change the test itself.