seth127
commented
2 years ago I still don't totally have my head around this, but I wanted to bring this up: the main reason we (at Metrum) use pkgr and renv together is so that renv can isolate the R environment and each project can know that it's using only the packages from the isolated environment (previously always within <project>/renv/library/).
Does this new tools::R_user_dir("renv", "cache") pattern break that? In other words, if we make pkgr work with tools::R_user_dir("renv", "cache") then are we essentially disabling the environment isolation? Or is renv still keeping track of which version of a given package from renv/cache it wants at a project level?
If the new pattern does disable that isolation, we could look into manipulating RENV_PATHS_LIBRARY (probably in the .Rprofile of our project template).
kyleam
dpastoor
renv v0.15 comes with the following change:
This new default doesn't play well with pkgr's assumption that the library is under
$(project_root)/renv/.../.https://github.com/metrumresearchgroup/pkgr/blob/e8fb3aa731a8d73065a1265c96f6bbc583ba70af/configlib/config.go#L104-L110
With earlier versions of renv, the pkgr logic could be thrown off by setting
RENV_PATHS_LIBRARYto a location other than the default library under the projectrenv/. However, with v0.15, this incompatible state is now the default.Below the fold is a demo of the issue that shows that a pkgr-installed library can't be located when using renv v0.15.0.
demo
Note: this script requires `usethis` and `renv` (before v0.15) to be available in default R environment. ```sh #!/bin/sh set -eux tdir=$(mktemp -d "${TMPDIR:-/tmp}"/fakepkgXXXXXX) cd "$tdir" Rscript -e 'usethis::create_package(".")' >/dev/null 2>&1 git init -q && git add . && git commit -qm'create package' ### pkgr setup ######################################################### printf "%s\n" "$(pkgr --version)" cat >pkgr.yml <<'EOF' Version: 1 Descriptions: - DESCRIPTION Packages: - httr2 Repos: - CRAN: https://cran.rstudio.com Lockfile: Type: renv EOF git add pkgr.yml && git commit -qm'add pkgr.yml' ### renv 0.14.0 ######################################################## Rscript -e 'renv::init(bare = TRUE)' git add . && git commit -qm'renv setup' Rscript -e 'packageVersion("renv")' -e '.libPaths()' pkgr install >/dev/null 2>&1 Rscript -e "httr2::request" ### renv 0.15.0 ######################################################## # Note that the failure here is a database error that isn't relevant. Rscript -e 'renv::upgrade(version = "0.15.0")' 2>/dev/null || : git clean -qxfd Rscript -e 'renv::init(bare = TRUE)' Rscript -e 'packageVersion("renv")' -e '.libPaths()' pkgr install >/dev/null 2>&1 Rscript -e "httr2::request" || : libpath=$(Rscript -e 'cat(.libPaths()[1])') find "$libpath" | grep httr2 || echo 'No httr2 in lib path' find "./renv/" | grep -c httr2 ``` ``` + mktemp -d /tmp/fakepkgXXXXXX + tdir=/tmp/fakepkgrW0wUk + cd /tmp/fakepkgrW0wUk + Rscript -e usethis::create_package(".") + git init -q + git add . + git commit -qmcreate package + pkgr --version + printf %s\n v3.0.0-rc1 v3.0.0-rc1 + cat + git add pkgr.yml + git commit -qmadd pkgr.yml + Rscript -e renv::init(bare = TRUE) + git add . + git commit -qmrenv setup + Rscript -e packageVersion("renv") -e .libPaths() [1] ‘0.14.0’ [1] "/tmp/fakepkgrW0wUk/renv/library/R-4.1/x86_64-pc-linux-gnu" [2] "/tmp/RtmpnN2W6W/renv-system-library" + pkgr install + Rscript -e httr2::request function(base_url) { new_request(base_url) }