Adding tests for saving out different sized plots

metrumresearchgroup / pmforest

Create forest plots

https://metrumresearchgroup.github.io/pmforest

Other

2 stars 0 forks source link

Adding tests for saving out different sized plots #15

Closed seth127 closed 2 years ago

seth127 commented 2 years ago

Addressing the point made in https://github.com/metrumresearchgroup/pmforest/issues/11#issuecomment-1054500429

Another key test will be when you change the size of the plot... Whatever solution we implement, let's make sure there are vdiffr tests that explicitly output bigger and smaller plots, to be sure the alignment still looks right.

seth127 commented 2 years ago

sidenote on this: those snapshot plots look... bad. The text is all squished because the ratio is off. Might be out of scope for this package, but I wanted to mention it. I mean... I guess it's on the user to know what ratio they want to save their plot out to so that it looks good. Not sure though, something about the text so ugly worries me a little.

barrettk commented 2 years ago

What does bother me is the fact that the font seems to change depending on row number. Look at the caption specifically in the small one. The large one has the same issue. Obviously this is not present in the Rstudio viewer though.