search

metrumresearchgroup / pmplots

Plots for Pharmacometrics
https://metrumresearchgroup.github.io/pmplots
8 stars 1 forks source link

Refactor eta_covariate to accept integer data #104

Closed kylebaron closed 2 weeks ago

kylebaron commented 2 weeks ago

See #103

The primary finding was an error that is generated when you pass integer x data into eta_covariate(); that function dispatches to cont_cat() which will generate an error, asking for factor, character or logical. So that dispatch is fixed.

This PR also re-factors how discrete and continuous data are detected in checks across the package. This ensures consistent adjudication in different places, specifically the handling when calling eta_covariate().

kyleam commented 2 weeks ago

ensures consistent adjudication

Making me pull out the dictionary.