search

metrumresearchgroup / pmplots

Plots for Pharmacometrics
https://metrumresearchgroup.github.io/pmplots
8 stars 1 forks source link

Test Failures with New ggplot2 Release #70

Closed rymarinelli closed 7 months ago

rymarinelli commented 1 year ago

With the 3.4.0 release of ggplot2, test-dv-pred-ipred and test-layer are raising errors.

failures ``` > Sys.setenv("R_TESTS" = "") > library(testthat) > library(pmplots) Loading required package: ggplot2 > > test_check("pmplots", reporter="summary") cat: test-cat: W........ chunk: chunk data sets: .... col_label: test-col_label: ............... cont: test-cont: W. data: test-data: ... dv-pred-ipred: test-dv-pred-ipred: ...1.................... layer: test-layer: 234......................... list_plot: test-layer: .... opts: test-opts: .............. pairs: test-pairs: ............. pm_browser: pm-axis: test-pm-axis: ............... pm: test-pm: ....................................................................................................... required: test-required: ......... res_time: test-pm: ............................................. scatter: test-scatter: ..... split_plot: test-split_plot: ....... utils: test-utils: ..................... wrap: test-wrap: ................. ══ Warnings ════════════════════════════════════════════════════════════════════ 1. vector inputs for cont_cat [PMP-TEST-001] ('test-cat.R:12') - `aes_string()` was deprecated in ggplot2 3.0.0. ℹ Please use tidy evaluation ideoms with `aes()` 2. scatter plot IDs [PMP-TEST-007] ('test-cont.R:8') - Using `size` aesthetic for lines was deprecated in ggplot2 3.4.0. ℹ Please use `linewidth` instead. ══ Failed ══════════════════════════════════════════════════════════════════════ ── 1. Error ('test-dv-pred-ipred.R:23'): dv-pred-ipred basics [PMP-TEST-081] ─── Error in `dplyr::distinct(data1, colour, linetype, group, size)`: Must use existing variables. ✖ `size` not found in `.data`. Backtrace: 1. dplyr::distinct(data1, colour, linetype, group, size) at test-dv-pred-ipred.R:23:2 2. dplyr:::distinct.data.frame(data1, colour, linetype, group, size) at dplyr/R/distinct.R:63:2 ── 2. Failure ('test-layer.R:13'): layer_xx [PMP-TEST-009] ───────────────────── `x` not equal to layer_s(p). Component "layers": Component 2: Component 12: Component 5: Component 21: Component 1: Modes: ..., name Component "layers": Component 2: Component 12: Component 5: Component 21: Component 1: names for target but not for current Component "layers": Component 2: Component 12: Component 5: Component 21: Component 1: target is not list-like ── 3. Failure ('test-layer.R:15'): layer_xx [PMP-TEST-009] ───────────────────── `x` not equal to layer_h(p). Component "layers": Component 2: Component 12: Component 5: Component 21: Component 1: Modes: ..., name Component "layers": Component 2: Component 12: Component 5: Component 21: Component 1: names for target but not for current Component "layers": Component 2: Component 12: Component 5: Component 21: Component 1: target is not list-like ── 4. Failure ('test-layer.R:17'): layer_xx [PMP-TEST-009] ───────────────────── `x` not equal to layer_s(p). Component "layers": Component 2: Component 12: Component 5: Component 21: Component 1: Modes: ..., name Component "layers": Component 2: Component 12: Component 5: Component 21: Component 1: names for target but not for current Component "layers": Component 2: Component 12: Component 5: Component 21: Component 1: target is not list-like ══ DONE ════════════════════════════════════════════════════════════════════════ No one gets it right on their first try Error: Test failures Execution halted ```
kyleam commented 7 months ago

This was resolved by #71.