metrumresearchgroup / pmplots

Plots for Pharmacometrics
https://metrumresearchgroup.github.io/pmplots
8 stars 1 forks source link

Fix compatibility with ggplot2 3.5.0 #86

Closed kyleam closed 7 months ago

kyleam commented 7 months ago

Two changes in ggplot2 3.5.0 trigger pmplots failures:

This series fixes those problems. (See the commit messages for more details.)

To simplify the trans fix, the minimum ggplot2 version is increased to 3.5.0. There's precedence for that approach with the pmplots 0.3.6 release (described here). @kylebaron, please let me know if you think we should try to stay compatible with older ggplot2 versions in this case.

In addition the low-level tests I added, I did the following and didn't notice any issues: 1) interactively tested many of these functions and 2) rendered the site and scrolled through the various vignettes.

Closes #84.