Two changes in ggplot2 3.5.0 trigger pmplots failures:
the name argument in scale functions has been re-positioned (commit)
the trans argument in scale functions has been renamed to transform (commit)
This series fixes those problems. (See the commit messages for more details.)
To simplify the trans fix, the minimum ggplot2 version is increased to 3.5.0. There's precedence for that approach with the pmplots 0.3.6 release (described here). @kylebaron, please let me know if you think we should try to stay compatible with older ggplot2 versions in this case.
In addition the low-level tests I added, I did the following and didn't notice any issues: 1) interactively tested many of these functions and 2) rendered the site and scrolled through the various vignettes.
Two changes in ggplot2 3.5.0 trigger
pmplots
failures:the
name
argument in scale functions has been re-positioned (commit)the
trans
argument in scale functions has been renamed totransform
(commit)This series fixes those problems. (See the commit messages for more details.)
To simplify the
trans
fix, the minimum ggplot2 version is increased to 3.5.0. There's precedence for that approach with the pmplots 0.3.6 release (described here). @kylebaron, please let me know if you think we should try to stay compatible with older ggplot2 versions in this case.In addition the low-level tests I added, I did the following and didn't notice any issues: 1) interactively tested many of these functions and 2) rendered the site and scrolled through the various vignettes.
Closes #84.