Refactor denominator in pt_data_inventory

metrumresearchgroup / pmtables

TeX tables for pharmacometrics.

https://metrumresearchgroup.github.io/pmt-book

11 stars 1 forks source link

Refactor denominator in pt_data_inventory #222

Closed kylebaron closed 3 years ago

kylebaron commented 3 years ago

Issue #221

missing means DV is NA and BQL is 0
bql means BQL != 0 regardless of what is in DV
obs means (1) not missing and (2) bql ==0

See further information in the confluence doc.

kylebaron commented 3 years ago

Thanks for your review, @curtisKJ ; just checking that you reviewed the design doc in confluence and sign. off on that as well. Just comment here on that too.

curtisKJ commented 3 years ago

@kylebaron, looked at that, too. I agree with Mike that having the footers match the descriptions in the documentation would be helpful. So instead of OBS: Observations, it's OBS: Observations (Non-BLQ).

kylebaron commented 3 years ago

Thanks; will you open an issue to and say what the change is?

kylebaron commented 3 years ago

Write it like a user story:

"As a user, I want the footer to say ...."

You are asking for this and we'll do it.

curtisKJ commented 3 years ago

Issue created #228