search

metrumresearchgroup / simpar

Create Parameters for Simulation with Uncertainty
https://metrumresearchgroup.github.io/simpar/
3 stars 1 forks source link

simpar Validation #9

Closed rymarinelli closed 1 year ago

rymarinelli commented 1 year ago

https://metworx.atlassian.net/browse/TDT-146

seth127 commented 1 year ago

This looks great, and the docs that were created from it are looking good. I think my only comment is to update the NEWS.md file for the new release. I think it should look like this:

# simpar 0.1.1

- This release adds documentation for validation purposes, but makes no functional changes.

# simpar 0.1.0

- The minimum number of degrees of freedom when simulating OMEGA or SIGMA
  is equal to the number of rows in the matrix rather than the length (#6)

- Add a `NEWS.md` file to track changes to the package
kylebaron commented 1 year ago

LGTM; a couple of suggestions on wording. Thanks for punching this out, @rymarinelli .

rymarinelli commented 1 year ago

@seth127 I just added the wording. Do we want to do a tag released with drone?