metwork-framework / mfserv

metwork/mfserv module
http://metwork-framework.org
BSD 3-Clause "New" or "Revised" License
12 stars 6 forks source link

Possible wrong use of the word "eventually" in mfserv logs #282

Closed zgalki closed 4 years ago

zgalki commented 4 years ago

Hi, Does the use of "eventually" in these files meant to be "possibly, potentially" or "finally" ?

bin/mfserv.init:echo -n "- Eventually stopping ${MODULE_LOWERCASE} module..."
opt/python3/lib/python3.5/site-packages/gunicorn/six.py:        self.__get_module(fullname)  # eventually raises ImportError
share/bash_profile:# We eventually override with custom module wide settings
share/bashrc:# We eventually override with system wide custom settings
share/bashrc:# We eventually override with module wide custom settings

As I understand it when it appears it seems to mean "possibly" not "finally"

thebaptiste commented 4 years ago

It means "possibly", we should change it. You are right, "eventually" is a "false friend" in french, it looks like "éventuellement", french word for "possibly", but it means "finally"...

Damned, we are unmasked, we are French people !

thebaptiste commented 4 years ago

Note : for six.py, it's not Metwork code (we only build the package), so we won't change any comment in this code.

thebaptiste commented 4 years ago

Closed by 0a595af