search

metwork-framework / mfserv

metwork/mfserv module
http://metwork-framework.org
BSD 3-Clause "New" or "Revised" License
12 stars 6 forks source link

.release_ignore instead of .releaseignore in common.mk #607

Closed matthieumarrast closed 1 year ago

matthieumarrast commented 1 year ago

File https://github.com/metwork-framework/mfserv/blob/master/plugins/common.mk declares .release_ignore whereas it should be .releaseignore (without underscore) (as per mfplugin code) : 

precustom:: .layerapi2_label .layerapi2_dependencies .release_ignore .plugin_format_version .gitignore .autorestart_includes .autorestart_excludes

.release_ignore: ../../adm/templates/plugins/_common/releaseignore
    cp -f $< $@

.gitignore:
    [...]
    echo ".release_ignore" >>$@
[...]

clean::
    [...]
    rm -f .release_ignore

What is the purpose of this common.mk file ? it seems to be used while "making" the "welcome" plugin ... But if we go to the path of installed "welcome" plugin, calling "make" raises the below error:

[mfserv:~/var/plugins/welcome]↥ $ make release
Makefile:2: ../common.mk: Aucun fichier ou dossier de ce type
make: *** Aucune règle pour fabriquer la cible « ../common.mk ». Arrêt.