search

metz-sh / simulacrum

Code-playground to visualise complex engineering flows.
https://metz.sh
Apache License 2.0
400 stars 28 forks source link

Color is too dark #36

Open lclalalalala opened 1 month ago

lclalalalala commented 1 month ago

Hey, this project is really cool! However, I am feeling really hard to see clearly on the screen. Everything is just so dark. The box boundaries, the background, the text. Please consider make a brighter theme.

iostreamer-X commented 1 month ago

Thanks @lclalalalala for bringing this up! I won't be able to fix this right away since other issues are in the pipeline, but I will definitely be adding support for themes in general.

IbrahimHamshari commented 1 month ago

Hey @iostreamer-X, if you don't mind I can start working on this.

iostreamer-X commented 1 month ago

Hello @IbrahimHamshari, that sounds great!

Feel free to join slack to discuss. Or we can do it here on github.

SahilLamba0008 commented 1 month ago

Hey @iostreamer-X , can i work on this as well ?

iostreamer-X commented 1 month ago

Hey @SahilLamba0008 sure! I have assigned the issue to you. Please check out this discussion for more context #38.

SahilLamba0008 commented 1 month ago

Hey @SahilLamba0008 sure! I have assigned the issue to you. Please check out this discussion for more context #38.

Before I start coding, I’d like to confirm if I’ve understood the task correctly and if my proposed approach aligns with your expectations. Please feel free to correct me if I’m off track anywhere.

  1. I plan to modify theme.json as : { "dark": { "base": "vs-dark", "inherit": true, // others ... }, "light": { "base": "vs", "inherit": true, // others .... } }

  2. Then, I’ll add a button in monaco-editor.tsx to toggle the theme. I’ll use either a Zustand store, local storage, or session storage to persist the theme selection across page reloads or revisits.

iostreamer-X commented 1 month ago

Hey @SahilLamba0008 let's continue this here.