Refactor to solve inconsitences

[danconte72]

Function Names

Based on ng-meumobi-utils/Files public functions the names of functions are different

      service.download = download;
      service.decorateFile = decorateFile;
      service.remove = remove;
      service.list = api.getFilesFromLocalStorage;
      service.open = open;

should update openFile to open

Behavior

Update to be an Observable Data Service

• getDownloadedMediaObserver: Observable<Array[medium]>
  • Returns which files were downloaded
• getMediumObserver(medium): Observable
  • Start to observe a medium
• decorateMedium(medium): Promise
  • Decorate and set next value for getMediumObserver
• startDownload(medium): Promise
  • Download medium
  • Set next value for getMediumObserver when it started, finished or fail the download
  • Set next value for getDownloadedMediaObserver when download success
• abortDownload(medium): Promise
  • Abort medium download
  • Set next values for getMediumObserver
• removeDownload(medium): Promise
  • Remove the medium downloaded
  • Set next values for getMediumObserver
  • Set next value for getDownloadedMediaObserver when remove success
• openMedium(medium): Promise
  • Open the downloaded medium

Interface

Add the medium interface to project

export interface Medium {
    url: string;
    type: string;
    extension: string;
    status?: string,
    behavior?: {
        label: "string",
        icon: "string",
        download: string,
    },
    name?: string;
    path?: string;
    fullPath?: string;
}

references

• https://coryrylan.com/blog/angular-observable-data-services

[vdias38]

Naming inconsistency

Why "remove download" and "open medium" ? both are not manipulating same item (local file). You maintain inconsistency on naming.

The service handle 2 types of media: remote and local. For each type you associate actions:

• remote: download, abort
• local: list, set, open, delete (CRUD)

Maybe we should separate concerns and create 2 services to handle file-transfer and local-media-persistence, as done with AuthService and AuthPersistenceService