search

mevblocker / web

https://mevblocker.io
7 stars 1 forks source link

Handle error not allowing you to add the RPC network #25

Closed anxolin closed 1 year ago

anxolin commented 1 year ago

This PR handles the special case where some wallets don't allow you to use a different RPC node for Mainnet.

It will show a different message, inviting the user to ask for the feature to their Wallet. image

Partial fix for https://github.com/mevblocker/web/issues/24

Context

https://cowservices.slack.com/archives/C04UG6HF726/p1680086604508549

Test

Test in Metamask IOS and observe the new message

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
mevblocker-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 29, 2023 at 2:01PM (UTC)
elena-zh commented 1 year ago

Hey @anxolin , great! However, some nitpicks from my side:

  1. I think there is a typo: it should be doesn't' instead of 'don't'
  2. still, users can add a network manually in the mobile MM, so I think "so you can't be protected' sounds a bit tough. Maybe add 'so you need to add it manually' instead?
fairlighteth commented 1 year ago

Suggestion for text

Oh no! 😢 It looks like your wallet doesn't support automatic RPC changes to help protect you. You might be able to make the change manually, though. If you could let your wallet provider know about this, that would be awesome! Thanks for considering it!