mevblocker / web

https://mevblocker.io
7 stars 1 forks source link

Handle error with imtoken too #26

Closed anxolin closed 1 year ago

anxolin commented 1 year ago

Same as https://github.com/mevblocker/web/pull/25 but this time handles the issue with Im token

This PR handles the special case where some wallets don't allow you to use a different RPC node for Mainnet.

It will show a different message, inviting the user to ask for the feature to their Wallet. image

Partial fix for https://github.com/mevblocker/web/issues/24

Context

https://cowservices.slack.com/archives/C04UG6HF726/p1680086604508549

Test

Test in Metamask IOS and observe the new message

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
mevblocker-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 29, 2023 at 11:21AM (UTC)
elena-zh commented 1 year ago

Hey @anxolin , great job! Can we add the same message to all WC wallets for mobile devices? Like Trust, Alpha, 1Inch, ZenGo, etc.?

anxolin commented 1 year ago

@elena-zh I would need to go one by one... I will try to do some more, but can't promise i can do them all :) They are not coherent with the behaviour so i need to ad some add-hoc

Just add a checklist in an issue to keep track the ones we do