search

mewna / catnip

A reactive, fully-async Discord API wrapper for the JVM, built on RxJava 3.
https://discord.gg/yeF2HpP
BSD 3-Clause "New" or "Revised" License
151 stars 33 forks source link

build(deps-dev): bump mockito-core from 4.9.0 to 5.1.0 #722

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Bumps mockito-core from 4.9.0 to 5.1.0.

Release notes

Sourced from mockito-core's releases.

v5.1.0

Changelog generated by Shipkit Changelog Gradle Plugin

5.1.0

v5.0.0

Mockito 5: prepare for future JDK versions

For a while now, we have seen an increase in problems/incompatibilities with recent versions of the JDK due to our usage of JVM-internal API. Most notably, JDK 17 made some changes which are incompatible with the current subclass mockmaker. Therefore, to prepare for the future of JDK, we are making some core changes to ensure Mockito keeps on working.

Switch the default mockmaker to mockito-inline

Back in Mockito 2.7.6, we published a new mockmaker based on the "inline bytecode" principle. This mockmaker creates mocks manipulating bytecode equivalent within the original class such that its method implementations hook into the normal Mockito machinery. As a comparison, the subclass mockmaker generates "real" subclasses for mocks, to mimic the same behavior. While the approaches are similar, the inline mockmaker avoids certain restrictions that the JDK imposes. For example, it does not violate module boundaries (introduced in JDK 9, but more heavily used in JDK 17) and avoids the leaking of the creation of the subclass.

Massive thanks to community member @​reta who implemented this change.

Note: this does not affect mockito-android nor testing on Android.

When should I still be using the subclass mockmaker?

There are legitimate remaining use cases for the subclass mockmaker. For example, on the Graal VM's native image, the inline mockmaker will not work and the subclass mockmaker is the appropriate choice. Additionally, if you would like to avoid mocking final classes, using the subclass mockmaker is a possibibility. Note however that if you solely want to use the subclass mockmaker to avoid mocking final, you will run into the above mentioned issues on JDK 17+. We want to leave this choice up to our users, which is why we will keep on supporting the subclass mockmaker.

If you want to use the subclass mockmaker instead, you can use the new mockito-subclass artifact (published on Maven Central along with all our other artifacts).

... (truncated)

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
codecov[bot] commented 1 year ago

Codecov Report

Merging #722 (243535b) into mistress (bdf4bb4) will decrease coverage by 9.87%. The diff coverage is n/a.

@@              Coverage Diff              @@
##             mistress    #722      +/-   ##
=============================================
- Coverage       17.10%   7.24%   -9.87%     
+ Complexity        544     286     -258     
=============================================
  Files             288     288              
  Lines           11571   11571              
  Branches         1322    1322              
=============================================
- Hits             1979     838    -1141     
- Misses           9436   10676    +1240     
+ Partials          156      57      -99
Impacted Files Coverage Δ
...rc/main/java/com/mewna/catnip/util/UnitHelper.java 0.00% <0.00%> (-100.00%) :arrow_down:
...ava/com/mewna/catnip/entity/partials/HasGuild.java 0.00% <0.00%> (-100.00%) :arrow_down:
...a/com/mewna/catnip/entity/partials/HasChannel.java 0.00% <0.00%> (-100.00%) :arrow_down:
...ewna/catnip/util/pagination/ReactionPaginator.java 0.00% <0.00%> (-100.00%) :arrow_down:
...in/java/com/mewna/catnip/entity/user/UserFlag.java 0.00% <0.00%> (-96.78%) :arrow_down:
.../com/mewna/catnip/entity/misc/ApplicationFlag.java 0.00% <0.00%> (-95.24%) :arrow_down:
...main/java/com/mewna/catnip/rest/JsonErrorCode.java 0.00% <0.00%> (-94.51%) :arrow_down:
...a/com/mewna/catnip/entity/message/MessageType.java 0.00% <0.00%> (-93.75%) :arrow_down:
...va/com/mewna/catnip/entity/guild/GuildFeature.java 0.00% <0.00%> (-93.03%) :arrow_down:
src/main/java/com/mewna/catnip/rest/Routes.java 0.00% <0.00%> (-91.42%) :arrow_down:
... and 48 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

dependabot[bot] commented 1 year ago

Superseded by #723.