Closed nimit2801 closed 3 years ago
https://www.npmjs.com/package/node-sass @sansyrox
I'm happy to this is my second PR too. Also @sansyrox I couldn't make new PR this commit was automatically included in the existing PR.
This also solved another issue #16 with commit https://github.com/mexili/cssify/pull/21/commits/c5d75bf03b28eef9180c6864863e438ee0519d7a as suggested @sansyrox I've disabled minify temporarily and allowed to only css files from the browser. This would allow normal working of the css framework and help the project run smoothly.
I've made one small change in package.json made "server" : "nodemon server.js" => "server" : "node server.js" Reason: As new files were generated in on the backend in the temp folder the server was restarting detecting the temp files added which made the server restart, which can cause delay and loss API calls on the server.
I'll soon open one PR to minify the CSS versions. Thank You.
Hi @nimit2801 , can you please remove the package-lock.json from the commits? We don't commit them in the repo.
Hi @nimit2801, can you please remove the package-lock.json from the commits? We don't commit them in the repo.
yeah sure, I'll remove it from the commit.
@sansyrox
Hi @nimit2801 ,
Looks good. I would've given you marks of 50 + 50, i.e. two medium issues. But I'll give you 100 in a single one.
Description
The project won't work on the node versions above 15.xx, because there's a dependency node-sass that needs 14.xx and lower.
Motivation and Context
20
How Has This Been Tested?
Types of changes
Checklist: