Major refactor

[sansyrox]

Major Refactor! Needs Help!

Todo

• [x] Convert Classes to Function
• [x] Add the original landing page to this version
• [ ] Move out Component from Video.js render method to individual file.
• [x] Convert CSS to Scss files
• [ ] Move the ConnectToSocketServer function in Video.js file to a separate utils folder.
• [ ] Add Recoil

Now, the server has been separated out to a different repo.

To run the server, git clone this repo: https://github.com/mexili/incogly-backend

and use yarn dev command in both the repos

you all can fork the branch major_refactor and make the prs to this branch only.

All the issues will be labelled as hard as refactors are harder in general.

[sansyrox]

@pranay-simejia , this is the refactor PR.

[NishantJawla]

@sansyrox can I convert roompage.js from class-based component to a functional-based component

[sansyrox]

@NishantJawla , if you take a look at this Pr, the room page.js file has been removed.

we have two class components here, we need to change them

[Jassi10000-zz]

I work to work on #69 , pls assign me @sansyrox sir I have mentioned the issue assignment here

[nimit2801]

@sansyrox is the Todo here our issue list for this PR?

[sansyrox]

@nimit2801 , yes

[sansyrox]

@Jassi10000 , that is not an active issue anymore. All the issues that we are focussing on atm are present in this PR's description.

[Jassi10000-zz]

@Jassi10000 , that is not an active issue anymore. All the issues that we are focussing on atm are present in this PR's description.

This thing I didn't knew as this was opened in the issues list , ok close it then , so that others also don't get confused

[sansyrox]

This thing I didn't knew as this was opened in the issues list , ok close it then , so that others also don't get confused

No worries 😄 Would still love your contributions here.

[NishantJawla]

@sansyrox I have opened a pull request regarding the CSS to scss file conversion please see it

[sansyrox]

@sansyrox I have opened a pull request regarding the CSS to scss file conversion please see it

Merged!

[nimit2801]

hey, @sansyrox do we've to convert Class in Video.js and its methods to functional components?

[sansyrox]

Yes @nimit2801

[sansyrox]

@Jassi10000

looks good

It certainly doesn't. Please don't write blind reviews. Thanks!

[Jassi10000-zz]

@Jassi10000

looks good

It certainly doesn't. Please don't write blind reviews. Thanks!

I just commented on the code that was changed to functional component , that was looking fine to me

[sansyrox]

Makes sense. Let us deploy the server and try to have the next convo on incogly only. 🔥

On Sun, 20 Jun 2021 at 7:14 PM, Raghav Dhingra @.***> wrote:

@.**** commented on this pull request.

In src/components/Video/index_old.jsx https://github.com/mexili/incogly/pull/67#discussion_r654938118:

@@ -0,0 +1,793 @@ +import React, { useCallback, useEffect, useRef, useState } from "react";

If index.jsx file is tested thoroughly then we can delete the old jsx file @sansyrox https://github.com/sansyrox

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mexili/incogly/pull/67#discussion_r654938118, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHEOIBSZVNLVKFZHPYWDMOTTTXWC7ANCNFSM4XPHMOXA .

[raghavdhingra]

Definitely 💪

[sansyrox]

closing pr.

Made it the default