mexili / incogly

Incogly is a video conferencing app aimed to remove any implicit bias in an interview and easing the process of remote collaboration.
https://incogly.mexili.org/
GNU Affero General Public License v3.0
28 stars 30 forks source link

Feature request #70

Closed Jassi10000-zz closed 3 years ago

Jassi10000-zz commented 3 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is.

  1. In the steps to get started with the Installation , the 3. step is written wrong in the ReadMe , due to which many of my beginner friends are facing issues -----> Its written " yarn && node server.js"
  2. In the steps it's my suggestion to please include this point that any contributor first has to install node modules or typically express , but yeah something related to installation should be written

These 2 are the problems faced by some beginners who are willing to contribute but getting confused

Describe the solution you'd like A clear and concise description of what you want to happen.

  1. I want to correct the 3. step to " yarn or node server.js "
  2. I want to include in the readme to install the necessary package or module which is needed to run the following command "node server.js" or "yarn server.js"

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered. No, the correct steps I mentioned will help everyone to go smooth

Approach to be followed (optional) A clear and concise description of approach to be followed.

Additional context Add any other context or screenshots about the feature request here.

welcome[bot] commented 3 years ago

Hello there!πŸ‘‹ Welcome to the project!πŸš€βš‘

Thank you and congratsπŸŽ‰for opening your very first issue in this project. Please adhere to our Contributing Guidelines.πŸ™Œ You may submit a PR if you like, make sure to follow our Pull Request Template. If you want to report a bug🐞 please follow our Issue Template. Also make sure you include steps to reproduce it and be patient while we get back to you.πŸ˜„

Feel free to join our Discord Community.πŸ’– We have different channels for active discussions.✨ Hope you have a great time there!πŸ˜„

lopeselio commented 3 years ago

Hey but yarn installs all packages and node server.js is used to run the server behind the application. Which I guess is not a problem.

Jassi10000-zz commented 3 years ago

@lopeselio Acc to my knowledge , you can either use yarn or (npm) [the package manager of node ]

Both can't be used together Btw with " node " also we can install all packages

Jassi10000-zz commented 3 years ago

@sansyrox Can you pls have a look over my issue raised , it's it seems suitable pls assign me so that I can move forward to correct the docs

sansyrox commented 3 years ago

Yarn is a package manager.

Node is a RTE.

@Jassi10000 , you can read more about them here: https://stackoverflow.com/questions/41675848/what-is-the-difference-between-node-js-runtime-and-npm-package-manager-options-w/41676076#:~:text=js%20runtime%20is%20basically%20what,by%20using%20the%20command%20line.

Jassi10000-zz commented 3 years ago

Yarn is a package manager.

Node is a RTE.

@Jassi10000 , you can read more about them here: https://stackoverflow.com/questions/41675848/what-is-the-difference-between-node-js-runtime-and-npm-package-manager-options-w/41676076#:~:text=js%20runtime%20is%20basically%20what,by%20using%20the%20command%20line.

Npm , is also the package manager of Node , its a choice to use yarn or npm

sansyrox commented 3 years ago

Screenshot 2021-02-17 at 5 50 07 PM

Npm , is also the package manager of Node , its a choice to use yarn or npm

Yes @Jassi10000 , I am aware of that. Thought of clarifying your issue πŸ˜„

Jassi10000-zz commented 3 years ago

Screenshot 2021-02-17 at 5 50 07 PM

Npm , is also the package manager of Node , its a choice to use yarn or npm

Yes @Jassi10000 , I am aware of that. Thought of clarifying your issue πŸ˜„

No issues sir ,πŸ˜„πŸ€™