search

mexmer / ScienceCostTweakerM

Factorio Mod : Adjusts the cost of science packs and research.
https://mods.factorio.com/mod/ScienceCostTweakerM/
GNU General Public License v3.0
6 stars 16 forks source link

Show made_in machine for "tweaked" science packs #96

Closed dmeltzer closed 9 months ago

dmeltzer commented 10 months ago

Tweaked science packs for various mods didn't always show the assembler the pack could be made in. The generic packs did. This arbitrarily standardizes on always showing them.

I think it's just as valid to never show them, but this seems to be the intended approach of the mod?

mexmer commented 10 months ago

it was not necessary, because science packs are usually made in assemblers. unless someone changes crafting category, it's not needed.

and i have no idea, about what you mean by intended approach of mod.

dmeltzer commented 9 months ago

All of the packs in prototypes/recipes/sciencepacks explictly have always_show_made_in=true. My comment about intended approach of the mod was a "majority rules" thought on these changes. (See 948330836d29180535b8e63b7c8bc64fe9aa8398) I'm happy to adjust this PR to remove the always_show_made_in everywhere--it's probably cleaner?

mexmer commented 9 months ago

i see, i totally forgot i made that change. and yes, you are right, it makes sense, to add this also to other mod science packs, and not just vanilla ones.