search

meyayl / docker-languagetool

GNU Lesser General Public License v2.1
71 stars 11 forks source link

Build multi-arch #9

Closed sbonnick closed 1 year ago

sbonnick commented 1 year ago

Hi, I was trying out your image since compared to others, it auto handles the download of models. However, I noticed you are currently only building for AMD64 (X86-64). Personally I am looking to run this on a ARM. When you have a few cycles, mind adding support to build for ARM too?

If it helps, here is some instructions on how to do multi-arch builds using github actions: https://dev.to/cloudx/multi-arch-docker-images-the-easy-way-with-github-actions-4k54

meyayl commented 1 year ago

Hi sbonnick! In the beginning I looked at other LanguageTool images, and remember seeing that they used arm specific fixes. That's why I decided against creating a multi-arch build. I don't feel comfortable maintaining something that I am not able to test myself. I hope you can understand.

If someone is willing to claim ownership for maintaining the image for other architectures, I gladly accept PR's.

Update: I couldn't recall it yesterday, but multi-arch is not going to happen the way the image is designed. I use Alpine as base image for security reasons, and Eclipse Temurin as base to compile a tailored Java runtime for LanguageTool. Eclipse Temurin only exist for Alpine on the x86_64 architecture. I don't plan to move to another base image or to use a different Java runtime.

Someone will have to fork the project and replace Alpine with Ubuntu, adapt the Dockerfile for multi-arch support and build their own images. It shouldn't be that hard.