codecov[bot] commented 3 years ago

Codecov Report

Merging #493 (53b3d47) into master (2fdf51b) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #493   +/-   ##
=======================================
  Coverage   45.44%   45.44%           
=======================================
  Files          17       17           
  Lines        1439     1439           
=======================================
  Hits          654      654           
  Misses        785      785

Flag	Coverage Δ
unittests	`45.44% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2fdf51b...53b3d47. Read the comment docs.

aarmey commented 3 years ago

@mcreixell this should be ready to merge. Please verify that you're seeing identical results first.

aarmey commented 3 years ago

After we merge this, I'll delete the separate repository I've been maintaining. Because of this, it will be important to merge these changes onto other branches.

mcreixell commented 3 years ago

The results are identical. Should I change the .from_samples() to DDMC with w=0 here or on a separate branch?

aarmey commented 3 years ago

Great. We can do that after merging this.

meyer-lab / DDMC

Move pomegranate within repository #493

Codecov Report