meyer-lab / DDMC

Clusters phosphoproteomics data based on a combination of the sequence information and abundance changes over conditions.
https://asmlab.org
1 stars 1 forks source link

Cleanup to get figures building again #533

Closed aarmey closed 8 months ago

codecov[bot] commented 9 months ago

Codecov Report

Attention: 134 lines in your changes are missing coverage. Please review.

Comparison is base (4333278) 29.04% compared to head (e655695) 43.25%. Report is 1 commits behind head on main.

Files Patch % Lines
ddmc/datasets.py 40.42% 56 Missing :warning:
ddmc/clustering.py 46.91% 43 Missing :warning:
ddmc/motifs.py 28.57% 20 Missing :warning:
ddmc/logistic_regression.py 0.00% 15 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #533 +/- ## =========================================== + Coverage 29.04% 43.25% +14.21% =========================================== Files 12 8 -4 Lines 1002 615 -387 =========================================== - Hits 291 266 -25 + Misses 711 349 -362 ``` | [Flag](https://app.codecov.io/gh/meyer-lab/DDMC/pull/533/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meyer-lab) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/meyer-lab/DDMC/pull/533/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meyer-lab) | `43.25% <56.91%> (+14.21%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=meyer-lab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

armaan-abraham commented 9 months ago

@aarmey

aarmey commented 9 months ago

@armaan-abraham thanks again for putting this together. I am ~40% through reviewing everything. Could you please take a look at the build errors? It looks like there are a few simple fixes there.