search

meyer-lab / FcRegression.jl

Study Fc antibody dynamics using a multivalent binding model
2 stars 0 forks source link

Regression restructuring #263

Closed cyrillustan closed 3 years ago

cyrillustan commented 4 years ago

@stephendl102 I disabled figureB1() because multiple things break. You can check on that and fix it later.

stephendl102 commented 4 years ago

Great. A big jump in progress. I'll check it out this Sunday and fix any breaks I find. @cyrillustan

aarmey commented 3 years ago

@cyrillustan @stephendl102 is this ready to merge? If the synergy calculation is blocking it, perhaps we can merge and open an issue?

stephendl102 commented 3 years ago

@aarmey From what I understand, the synergy calculation is working but there is still a slight difference in fitRegression which has been proving elusive. This is causing a difference in subplot c, e, and f for the disease model plots. I will look into this more this upcoming week. Also, I should be able to attend meetings again next week as my job ends this Friday.

cyrillustan commented 3 years ago

I'll come back to this next week, and I'll merge it by the end of the next week.

codecov-commenter commented 3 years ago

Codecov Report

Merging #263 into master will increase coverage by 13.29%. The diff coverage is 61.36%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #263       +/-   ##
===========================================
+ Coverage   18.89%   32.18%   +13.29%     
===========================================
  Files          18       18               
  Lines         741      783       +42     
===========================================
+ Hits          140      252      +112     
+ Misses        601      531       -70
Impacted Files Coverage Δ
src/FcRegression.jl 3.70% <ø> (+0.25%) :arrow_up:
src/dataHelpers.jl 87.85% <ø> (+2.80%) :arrow_up:
src/figures/figureB1.jl 0.00% <0.00%> (ø)
src/figures/figureS.jl 0.00% <0.00%> (ø)
src/figures/figureW.jl 0.00% <0.00%> (ø)
src/fitActI.jl 0.00% <0.00%> (ø)
src/mixture.jl 0.00% <0.00%> (ø)
src/synergy.jl 0.00% <0.00%> (ø)
src/fcBindingModel.jl 76.47% <63.63%> (+21.92%) :arrow_up:
src/regression.jl 96.64% <97.70%> (+60.64%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b9f2635...fdf3b14. Read the comment docs.