search

meyer-lab / FcRegression.jl

Study Fc antibody dynamics using a multivalent binding model
2 stars 0 forks source link

Edit manuscript #297

Closed stephendl102 closed 3 years ago

stephendl102 commented 3 years ago

@aarmey @cyrillustan So, I'm realizing that a test for testMix is causing my pull requests to fail. Do either of you know how to fix it? I gave it a try in my last commit, so that might need to be undone.

aarmey commented 3 years ago

This has been intermittently failing for a while, I believe. @cyrillustan is probably best equipped to fix.

cyrillustan commented 3 years ago

You can just mute the testMixture if that is the case.

codecov-io commented 3 years ago

Codecov Report

Merging #297 (2c633b1) into master (3e39c74) will decrease coverage by 1.00%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
- Coverage   28.15%   27.15%   -1.01%     
==========================================
  Files          19       19              
  Lines         927      928       +1     
==========================================
- Hits          261      252       -9     
- Misses        666      676      +10
Impacted Files Coverage Δ
src/mixture.jl 0.00% <0.00%> (-6.17%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0054875...2c633b1. Read the comment docs.

stephendl102 commented 3 years ago

@cyrillustan Ok, I did that. Now dataFrames is not working?

stephendl102 commented 3 years ago

@aarmey Is there anything I need to do to make codecov pass?

aarmey commented 3 years ago

Nope. Ignore it.