meyer-lab / systemsSerology

Dissecting systems serology with a tensor factorization

https://asmlab.org

3 stars 2 forks source link

Hakan alter bootstrapping #282

Closed Kimeiga closed 3 years ago

Kimeiga commented 3 years ago

I have tried f.tight_layout() f.subplots_adjust(hspace=10.0, wspace=1.0) and subplotLabel() (thinking it might handle the spacing too)

Nothing spaces the figures out properly. SOS.

After that is done, I think the figure is ready.

cyrillustan commented 3 years ago

Can you put more space into these subplots? They are overlapping.

codecov[bot] commented 3 years ago

Codecov Report

Merging #282 (cc29a30) into master (e2a8b98) will not change coverage. The diff coverage is n/a.

:exclamation: Current head cc29a30 differs from pull request most recent head d62e657. Consider uploading reports for the commit d62e657 to get more accurate results

@@           Coverage Diff           @@
##           master     #282   +/-   ##
=======================================
  Coverage   86.17%   86.17%           
=======================================
  Files           7        7           
  Lines         405      405           
=======================================
  Hits          349      349           
  Misses         56       56

Flag	Coverage Δ
unittests	`86.17% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9239961...d62e657. Read the comment docs.

aarmey commented 3 years ago

This is great! I have a subtle discomfort with this way of presenting things, but it will be easier to discuss tomorrow on Zoom.

Kimeiga commented 3 years ago

Can you put more space into these subplots? They are overlapping.

haha I have tried 3 ways to no avail. I documented this on the slack thread too but when I tried different ways of spacing, it would make heights of the graphs tiny; I couldn't figure it out

cyrillustan commented 3 years ago

I think the built version here shows that the texts are complete, but the figures are too small

Kimeiga commented 3 years ago

Here is my attempt with tight_layout() Here is my attempt with f.subplots_adjust(hspace=10.0, wspace=1.0)

It makes ample room for the labels and text, but then the graphs get too small. SOS

aarmey commented 3 years ago

Swap the x- and y-axes, then the text labels would be horizontal.

Kimeiga commented 3 years ago

current state: ![Uploading image.png…]()

cyrillustan commented 3 years ago

Btw, all supplemental figures will be call EV from now on. (So Fig. EV3 instead of Fig. S3)

aarmey commented 3 years ago

Note that I've put X scaling inside RegressionHelper, so you won't find it in this PR anymore.

aarmey commented 3 years ago

Merging!