search

meyer-lab / tHMM

A general Python framework for using hidden Markov models on binary trees or cell lineage trees.
https://asmlab.org
MIT License
10 stars 1 forks source link

reviewer comments #906

Closed Farnazmdi closed 2 years ago

Farnazmdi commented 2 years ago
  1. figure6.py updated, baseline classifier instead of kmeans. In the next comment I wrote the mathematical expression I used for the threshold for the classifier.
  2. changed "Random Index accuracy" to "Adjusted Rand Index" in all figures (I will ask JC to change this in the figures that we won't re-make).
codecov[bot] commented 2 years ago

Codecov Report

Merging #906 (e21c15b) into master (f432645) will increase coverage by 0.04%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
+ Coverage   81.34%   81.38%   +0.04%     
==========================================
  Files          26       26              
  Lines        2160     2160              
==========================================
+ Hits         1757     1758       +1     
+ Misses        403      402       -1
Flag Coverage Δ
unittests 81.38% <ø> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lineage/states/stateCommon.py 94.44% <0.00%> (+1.11%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Farnazmdi commented 2 years ago

image image