search

meyer-lab / tensorpack

A collection of tensor methods from the Meyer lab.
MIT License
2 stars 2 forks source link

Updating plots.py #40

Closed ethanhung11 closed 2 years ago

ethanhung11 commented 2 years ago

fixing up plots.py, added common.py for testing purposes (can remove later if unnecessary)

codecov[bot] commented 2 years ago

Codecov Report

Merging #40 (97cbda9) into main (423a731) will decrease coverage by 7.25%. The diff coverage is 2.77%.

:exclamation: Current head 97cbda9 differs from pull request most recent head b8ee6f2. Consider uploading reports for the commit b8ee6f2 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   87.67%   80.42%   -7.26%     
==========================================
  Files           7        8       +1     
  Lines         568      618      +50     
==========================================
- Hits          498      497       -1     
- Misses         70      121      +51
Flag Coverage Δ
unittests 80.42% <2.77%> (-7.26%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tensorpack/plot.py 0.00% <0.00%> (ø)
tensorpack/test/common.py 0.00% <0.00%> (ø)
tensorpack/test/test_decomposition.py 100.00% <ø> (ø)
tensorpack/decomposition.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 423a731...b8ee6f2. Read the comment docs.

ethanhung11 commented 2 years ago

pos has been removed

ethanhung11 commented 2 years ago

I've fixed the first and third issues, but for 2) how should I notate large negative values? The graphs graph the mean and standard mean error and do not actually show individual negative outliers. Is there a standard practice for this?

cyrillustan commented 2 years ago

You can leave the individual outliers alone. From what I see component >=3 are entirely blank, so we certainly need to make it better. Merge this PR first, and we can open a new one to solve this.