meyerhoferc / secret-santa

0 stars 0 forks source link

User groups #12

Closed kmeyerhofer closed 6 years ago

kmeyerhofer commented 6 years ago

Adds the following functionality:

Groups

  1. A user can create a group.
  2. A user can view the group page.
  3. A user can edit the group information.
  4. A user can delete the group.
  5. A user can view the users belonging to a group.

Users

  1. A user can view their profile.
  2. A user can edit their First and Last name, Email, or Password, from either the /profile or /profile/:id paths.
  3. A user can edit their Email.
  4. A user can edit their Password.
  5. A user can view another user's profile (url: /profile/:id)

Dashboard

  1. Once a user is logged in, their default page is /dashboard which shows their groups they belong to and a link to create a new group
meyerhoferc commented 6 years ago

Also forgot to mention -- accurate commit logs 👍

kmeyerhofer commented 6 years ago

The requested changes have been addressed and corrected.

meyerhoferc commented 6 years ago

Note on commit messages: the message generally should explain what the code change does, not the implementation or how the code makes that change.

e.g. "Adds a check for authorized user before displaying XYZ page." instead of "Adds a before_action for the XYZController show page to check for authorized user."

meyerhoferc commented 6 years ago

@kmeyerhofer Thank you for all of your work on this!

Documenting that the seeds file runs into a uniqueness validation error when running for me locally. Creating fewer user records seems to do the trick. I don't think you need to change it for this PR -- just making note of it.

I'm also getting a spec failure on spec/features/users/user_can_signup_spec.rb. Is this expected on this branch?

kmeyerhofer commented 6 years ago

I've made a note of the commit messages, thanks.

The seeds are fixed in branch #14 , the uniquness is definitely addressed there.

I just fixed the failing tests for spec/features/users/user_can_signup_spec.rb