Closed kmeyerhofer closed 6 years ago
Also forgot to mention -- accurate commit logs 👍
The requested changes have been addressed and corrected.
Note on commit messages: the message generally should explain what the code change does, not the implementation or how the code makes that change.
e.g. "Adds a check for authorized user before displaying XYZ page." instead of "Adds a before_action for the XYZController show page to check for authorized user."
@kmeyerhofer Thank you for all of your work on this!
Documenting that the seeds file runs into a uniqueness validation error when running for me locally. Creating fewer user records seems to do the trick. I don't think you need to change it for this PR -- just making note of it.
I'm also getting a spec failure on spec/features/users/user_can_signup_spec.rb
. Is this expected on this branch?
I've made a note of the commit messages, thanks.
The seeds are fixed in branch #14 , the uniquness is definitely addressed there.
I just fixed the failing tests for spec/features/users/user_can_signup_spec.rb
Adds the following functionality:
Groups
Users
/profile
or/profile/:id
paths./profile/:id
)Dashboard
/dashboard
which shows their groups they belong to and a link to create a new group