search

meyerhoferc / secret-santa

0 stars 0 forks source link

Wish list #13

Closed kmeyerhofer closed 5 years ago

kmeyerhofer commented 6 years ago

This PR's base is based on PR #12 This PR adds the following features:

Groups

  1. When creating a group, the owning user has a wish list created with their id and the group's id.
  2. Groups hold the nested resources of lists and items within the config/routes.rb file.

Lists

  1. A list references a group and a user.
  2. A list is visible on the group page, next to each user. #4
  3. A list can be referenced by many items.

Items #3

  1. An item references a list.
  2. An item has full CRUD functionality, editable by its owner only, but viewable by anyone.

Tests

  1. Some tests about logging in and users have been updated. (More testing to continue.)
meyerhoferc commented 6 years ago

Why is this PR against user-groups instead of master?

meyerhoferc commented 6 years ago

Functional review: ( I will add in GH issues for each of these )

kmeyerhofer commented 5 years ago

The recent commits address all the comments made above.

Issues #17 and #18 has been fixed and addressed. application_controller.rb has helper methods to check if a user is logged in, and if a user is allowed to modify an Item or Group.