Closed kmeyerhofer closed 5 years ago
@kmeyerhofer Please resolve merge conflicts. I think this are appearing because I just merged wish-list
into master
.
invitation.user
but not user.invitations
. I think this is because the Invitation
model has two relationships called user
set./accept/:invitation_id
Functional Testing Notes
Invitations
* Why are invitations on the user's show page? I don't see a way to find users other than knowing their ID to invite them to the group.
I wanted to have a second way for a group owner to invite someone. Yes, you do have to know their ID to invite them, that is definitely a big downside. I planned on adding a "request to join group" functionality which would allow a user to request to join a group. This might be added in the future.
- In console, noticed issue with relationship between user + invitations. Can do
invitation.user
but notuser.invitations
. I think this is because theInvitation
model has two relationships calleduser
set. Fixed.Invitation
now belongs tosender
andreceiver
andUser
now has manyreceived
andsent
- Invitations has show route but not action
Show route removed.
* I am able to accept another user's invitation by manually typing in `/accept/:invitation_id`
Fixed.
- Unsure if this needs to be addressed: I was able to be added to a group twice when working through the console but not through the interface. Fixed. Adds
validates_uniqueness_of :user_id, scope: :group_id
touser_groups
modelGroups
* works as advertised
Users
* Only issue is unable to update password, which I know you are working on separately.
This is being worked on in branch
username
.
This PR's base is based on PR #13
Invitations Added
As a group owner, you can invite a user to join the group. Your invite can contain a message to the user. You can invite a user in two ways:
/users/:id
) it will show a drop down menu of the groups you are an owner of. Select the group, write a message and submit your invitation to that user.You can only send one invitation to a user at a time. If the user declines the invitation, you cannot invite them again.
If you have been invited to a group, your invitation will be at your
/dashboard
awaiting your Accept or Decline.Groups
groups#destroy
functionality for a group owner works correctly deleting allItem
s,List
s, and finally theGroup
itself.gift_due_date
date attributes. This is a required field during group creation and update. It will be used for business logic in the future.Users
User
email addresses are converted to downcase before being saved or accessed in the database.user#update
received a refactor: the current password is required to update any information for a user.Items
item#update
actions correctly.Gems
strong_password
Adds the
strong_password
gem. Users must use a strong password. Password strength is tested inspec/models/user_spec.rb
.database_cleaner
For testing only.
Gemfile
Dependency upgrades.
Database
Invitations
.db/seeds
updated to be more relevant for the new data.Tests!
users
,groups
,items
,invitations
rake
orrspec
, one is currently not yet implemented.