ArrayIndexOutOfBoundsException in AbstractPolychoricCorrelation

[pereferrera]

When this piece of code is run, invalid offsets are accessed within the x2 array:

    //Eliminate rows and columns with nonzero sums
    if(validRowcount!=nrow || validColCount!=ncol){
        double[][] x2 = new double[validRowcount][validColCount];
        int r=0;
        int c=0;
        N=0;
        for(int i=0;i<nrow;i++){
            c=0;
            for(int j=0;j<ncol;j++){
                x2[r][c] = data[goodRow[i]][goodCol[j]];
                N+=x2[r][c];
                c++;
            }
            r++;
        }
        data=x2;
        nrow = data.length;
        ncol = data[0].length;
    }

As I'm not quite sure what is supposed to happen at this point, I didn't submit a pull request.

[meyerjp3]

There's more work to be done with the polychoric correlations. Would you post a test case that causes the error? Thanks.

[pereferrera]

Done, see: https://github.com/meyerjp3/psychometrics/pull/6