search

meypod / al-azan

Privacy focused ad-free open-source muslim Adhan (islamic prayer times) and qibla app
https://meypod.github.io/al-azan/
GNU Affero General Public License v3.0
183 stars 26 forks source link

Missing accessibility labels #54

Closed mhameed closed 1 year ago

mhameed commented 1 year ago

Salaam, Jazak Allah kheer for releasing this app on fdroid.

I was wondering if you could add accessibility labels for the buttons, so that a blind person using talkback can successfully use the app.

Thank you.

meypod commented 1 year ago

Va alaykum assalam

I'm very busy at the moment but I will look into it when I have time

meypod commented 1 year ago

I need help on this one, I have little idea about what and where labels are missing and how a blind person might use the app (in what order the talkback reads the screen)

I mean it would be nice if someone could contribute this fix

mhameed commented 1 year ago

please see: https://support.google.com/accessibility/android/answer/7158690?hl=en-GB

the screenreader can usually be enabled via settings -> accessibility -> talkback but if you have not used it before, it might take some time to get use to. If you want we can have a video call and we can go through it in more detail.

Anyway, I will try to find the time to look at the code/send a pull request.

Thanks for your time.

meypod commented 1 year ago

Thanks for the link

Anyway, I will try to find the time to look at the code/send a pull request.

much appreciated

Tanzin01 commented 1 year ago

What's the status of this issue ? I can can make a pull request if required, In ShaAllah :)

meypod commented 1 year ago

I'm sorry, I'm in middle of a big migration to a yarn monorepo While I would love contribution, it would make it harder to migrate things I'll let you know when I finish migrating thank you

meypod commented 1 year ago

Well mono repo turned out to be a very bad idea for react native, sadly @Tanzin01 please make a PR whenever you have time, it is appreciated

meypod commented 1 year ago

I tried to add all missing labels please try the latest releases from GitHub if you can (1.17.0) will release it on fdroid and google play soon

feel free to open an issue again if there's any issue