search

meyt / linkpreview

Get link preview in python
MIT License
46 stars 9 forks source link

Added missing `lxml` requirement #16

Closed danriedl closed 1 year ago

danriedl commented 1 year ago

In order to use the lxml parser from bs4 it needs to be installed aswell: https://github.com/meyt/linkpreview#use-lxml-as-xml-parser

meyt commented 1 year ago

@danriedl lxml is recommended for where you need to have better performance. its not mandatory and we should stick to minimum dependencis as possible.

danriedl commented 1 year ago

@meyt , would be cool to mention it tho: https://github.com/meyt/linkpreview#use-lxml-as-xml-parser

meyt commented 1 year ago

@danriedl Of course, i'll update it. Thank you