search

meza / curseforge-fingerprint

Node binding for the fingerprinting algorithm curseforge is using
GNU General Public License v3.0
1 stars 1 forks source link

fix: fixed std::string untimely destroy #16

Closed OrbitZore closed 1 year ago

OrbitZore commented 1 year ago

path.Utf8Value() return const string which will destroy after define jar_file_path,therefore the jar_file_path is Dangling pointer. You can check this bug with a long jar file name,in my machine it is 15 bytes like abcdefghijk.jar.That will throw TypeError: Jar file was empty . Just create a std::string variable and get it's content pointer can fix this bug.

meza commented 1 year ago

Great catch, thanks!

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.0.11 :tada:

The release is available on:

Your semantic-release bot :package::rocket: